When using 'par-for-each', we'd spawn the whole thread pool of (ice-9
futures), with one thread per core.  Using 'n-par-for-each' allows us to
spawn just as many threads as needed.

* src/cuirass/scripts/evaluate.scm (cuirass-evaluate): Use
'n-par-for-each' instead of 'par-for-each'.

Fixes <https://issues.guix.gnu.org/55441>.

Regression introduced by Guix commit
bd86bbd300474204878e927f6cd3f0defa1662a5, where 'open-inferior' switched
from 'open-pipe*' to 'primitive-fork', thereby introducing a window
before 'execl' where the child process could get stuck on a mutex or
similar.

* src/cuirass/scripts/evaluate.scm (inferior-evaluation): Remove
'profile' argument and replace it by 'inferior'.  Remove 'open-inferior'
and 'close-inferior' calls.
(cuirass-evaluate): Call 'open-inferior' upfront.  Adjust 'par-for-each'
call accordingly.

* src/cuirass/scripts/evaluate.scm: Remove unnecessary module imports.
Use #:autoload and #:select.

* src/cuirass/scripts/evaluate.scm (inferior-evaluation): Add call to
'close-inferior'.

* src/cuirass/templates.scm (specification-edit): Forbid it.

Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>

Fixes: <https://issues.guix.gnu.org/55024

>.

* src/cuirass/http.scm (body->specification): Decode all arguments and not
only channel URL and build params.

Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>

* src/cuirass/templates.scm (html-page): Update it.

* tests/database.scm: Fix it.

* src/cuirass/database.scm (db-get-specification): Always return the requested
specification even if it is inactive.

* Makefile.am: Fix it.

This reverts commit 3d91c447. It also makes
sure that the scripts are compiled.

* src/cuirass/scripts/remote-server.scm (cuirass-remote-server): Set "COLUMNS"
to 500.

* Makefile.am (scriptsmoduledir, scriptsobjectdir, dist_scriptsmodule_DATA):
Remove them.
(dist_pkgmodule_DATA): Add the scripts.

* src/cuirass/scripts/remote-server.scm (cuirass-remote-server): Increase it.

Fixes: <https://issues.guix.gnu.org/52840>.

* src/cuirass/templates.scm (build-details): Display it.

Proposed by Leo Famulari here: <https://issues.guix.gnu.org/52487>.

* src/cuirass/database.scm (db-update-failed-builds!): Record the starttime
and stopttime.

Also distinguish between a build that is completed from a build that is
completed with some available logs.

* src/cuirass/templates.scm (completed?, completed-with-logs?): New
procedures.

* src/cuirass/scripts/remote-server.scm (cuirass-remote-server): Create the
cache-directory only once user privileges have been gathered.

* src/cuirass/remote.scm (receive-logs): Catch premature client disconnections
and report them.

* src/cuirass/scripts/remote-worker.scm (run-build): If the worker was not
able to send the build logs, report it, dump the build logs them and keep
things going.

* src/cuirass/remote.scm: Remove extra new-line.

* src/cuirass/scripts/remote-server.scm (zmq-start-proxy): Log wrongly
formatted messages.

* src/cuirass/database.scm (db-clear-build-queue): Ignore builds that are
already scheduled.

The specification used to build our master branch was renamed from
"guix-master" to "master".

* doc/cuirass.texi (API description): Change "guix-master" to "master".
* src/cuirass/templates.scm: Change "guix-master" to "master".

* src/cuirass/scripts/remote-server.scm (read-worker-exp): Turn log-info into
log-debug.

* src/cuirass/logging.scm (log-info, log-debug, log-warning, log-error): New procedures.
* src/cuirass/base.scm: Introduce log levels.
* src/cuirass/database.scm: Ditto.
* src/cuirass/http.scm: Ditto.
* src/cuirass/metrics.scm: Ditto.
* src/cuirass/notification.scm: Ditto.
* src/cuirass/remote.scm: Ditto.
* src/cuirass/scripts/register.scm: Ditto.
* src/cuirass/scripts/remote-server.scm: Ditto.
* src/cuirass/scripts/remote-worker.scm: Ditto.
* src/cuirass/scripts/web.scm: Ditto.
* src/cuirass/utils.scm: Ditto.
* src/cuirass/watchdog.scm: Ditto.

* src/cuirass/scripts/remote-server.scm (add-to-store): Add a drv argument.

* src/cuirass/scripts/remote-server.scm: Move trigger-substitutes-baking upper.

* src/cuirass/scripts/remote-server.scm: Fix typo.

* src/cuirass/scripts/remote-server.scm: Add missing include.

* src/cuirass/scripts/remote-server.scm (add-to-store): Take care of
registering the GC roots and triggering the baking if the ensure-path call is
successful.
(trigger-substitutes-baking): Take a single output argument.
(need-fetching?): Add logging.
(run-fetch): Adapt it.

* src/cuirass/scripts/remote-server.scm (ensure-path*): Catch &nar-error.

* src/cuirass/base.scm (register-gc-roots): Ignore ENOENT exceptions.
* src/cuirass/scripts/remote-server.scm (run-fetch): Adapt it.

Suggested-by: Ludovic Courtès <ludo@gnu.org>

The fetch workers could crash when trying to register gc-roots for a
derivation that has already been garbage collected.

2021-12-03T03:36:46 fetching '/gnu/store/kx2ci2h5fif7j4rv6xcfn2gqk0fjjwqy-mtm-1.2.1.drv' from http://10.0.0.7:5558
In ice-9/eval.scm:
    619:8  7 (_ #(#(#<directory (cuirass scripts remote-server) ?> ?)))
    619:8  6 (_ #(#(#(#(#(#(#<directory (cuirass scr?> ?)) ?) ?) ?) ?))
    619:8  5 (_ #(#(#(#(#(#(#(#(#(#(#(?) ?) ?) ?) ?) ?) ?) ?) ?) ?) ?))
In cuirass/base.scm:
   192:15  4 (register-gc-roots "/gnu/store/kx2ci2h5fif7j4rv6xcfn2g?" ?)
In guix/derivations.scm:
   549:17  3 (derivation-path->output-paths "/gnu/store/kx2ci2h5fif7?")
In ice-9/ports.scm:
   450:11  2 (call-with-input-file "/gnu/store/kx2ci2h5fif7j4rv6xcf?" ?)
In unknown file:
           1 (open-file "/gnu/store/kx2ci2h5fif7j4rv6xcfn2gqk0fjjwq?" ?)
In ice-9/boot-9.scm:
  1685:16  0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure open-file: No such file or directory: "/gnu/store/kx2ci2h5fif7j4rv6xcfn2gqk0fjjwqy-mtm-1.2.1.drv"

Do not try to register the derivation outputs in that case.

* src/cuirass/scripts/remote-server.scm (run-fetch): Check if the derivation
still exists before trying to register its outputs.

* src/cuirass/templates.scm (specifications-table): Handle specifications with
no evaluations.

Fixes: <https://issues.guix.gnu.org/51145>.

* src/cuirass/templates.scm (javascript-licenses): New procedure.
* src/cuirass/http.scm (url-handler): New /static/about/javascript route.

* src/cuirass/templates.scm (evaluation-dashboard): Add filter support.
* src/static/js/cuirass.js: Add dashboard filter support.

* src/cuirass/database.scm (db-get-latest-evaluations): Add a status
parameter.
* src/cuirass/templates.scm (specifications-table): Add a latest-evaluations
parameter.
* src/cuirass/http.scm (url-handler): Adapt it.
* tests/database.scm (db-get-latest-evaluations 2): New test.